Fix build warnings observed locally #73593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
reviewed
May 21, 2024
|
|
||
| <!-- | ||
| Make sure the _GetPackageFiles target exists, since it is always expected for design time builds, but only | ||
| defined when ImportNuGetBuildTasksPackTargetsFromSdk is true. |
There was a problem hiding this comment.
do you know when this is not true?
Wondering if the import of this file can be conditioned on the existence of the target or related condition - https://github.com/dotnet/roslyn/blob/main/src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj#L142
There was a problem hiding this comment.
I didn't make a note of this at the time, but it may be related to this:
| <ExcludeFromSourceBuild>true</ExcludeFromSourceBuild> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies.net45" /> |
There was a problem hiding this comment.
Why do we need the net45 reference assemblies and not e.g. the net472 ones?
There was a problem hiding this comment.
Not sure, but this fixes the issue.
tmat
reviewed
May 21, 2024
src/Tools/SemanticSearch/ReferenceAssemblies/SemanticSearch.ReferenceAssemblies.csproj
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Jun 10, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.