Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to file scoped namespace for tests #73634

Merged
merged 7 commits into from
May 22, 2024
Merged

Switch to file scoped namespace for tests #73634

merged 7 commits into from
May 22, 2024

Conversation

CyrusNajmabadi
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 22, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title Update to simple using statements WIP: Switch to file scoped namespace. May 22, 2024
@CyrusNajmabadi CyrusNajmabadi force-pushed the fileScopedNamespace branch 2 times, most recently from a55b46a to 9cc6677 Compare May 22, 2024 07:41
@CyrusNajmabadi CyrusNajmabadi changed the title WIP: Switch to file scoped namespace. Switch to file scoped namespace for tests May 22, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review May 22, 2024 17:08
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 22, 2024 17:08
ToddGrun
ToddGrun approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 22, 2024 17:13
@CyrusNajmabadi CyrusNajmabadi merged commit 3df090b into dotnet:main May 22, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the fileScopedNamespace branch May 22, 2024 19:11
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 22, 2024
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
This was referenced Jun 4, 2024
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @Cosifne