On the fly docs exclusion #73770
Merged
On the fly docs exclusion #73770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
genlu
reviewed
May 29, 2024
| @@ -145,6 +146,11 @@ protected override NullableFlowState GetNullabilityAnalysis(SemanticModel semant | |||
| return null; | |||
| } | |||
|
|
|||
| if (await copilotService.IsAnyExclusionAsync(cancellationToken).ConfigureAwait(false)) | |||
There was a problem hiding this comment.
not blocking the PR, but consider renaming to HasAnyExclusionAsync
genlu
approved these changes
May 29, 2024
Cosifne
approved these changes
May 29, 2024
3 tasks
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #73702 but retargeted to release branch.