Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support goto-def taking you from an interceptor method to the location being intercepted. #73992

Merged
merged 17 commits into from
Jun 14, 2024
Merged

Support goto-def taking you from an interceptor method to the location being intercepted. #73992

merged 17 commits into from
Jun 14, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jun 13, 2024 •
edited
Loading

One of a few navigation improvements i'm making for interceptors. Currently that list is:

  1. Navigate from interceptor to teh call it intercepts (this pr)
  2. Navigate from a callsite to the method intecepting it (and the original method the user was calling)
  3. Having find-references on an interceptor method (or call to method that is intercepted) show the relevant locations.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 13, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title WIP. Support goto-def taking you from an interceptor method to the location being intercepted. Jun 13, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review June 13, 2024 21:25
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 13, 2024 21:25
ToddGrun
ToddGrun approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@build-analysis build-analysis bot mentioned this pull request Jun 14, 2024
Open
3 tasks
@CyrusNajmabadi CyrusNajmabadi merged commit f372de7 into dotnet:main Jun 14, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 14, 2024
ToddGrun
ToddGrun reviewed Jun 14, 2024
View reviewed changes
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs

private async Task<Dictionary<ImmutableArray<byte>, DocumentId>> ComputeContentHashToDocumentIdAsync(CancellationToken cancellationToken)
{
var result = new Dictionary<ImmutableArray<byte>, DocumentId>(ImmutableArrayComparer<byte>.Instance);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dictionary

Isn't it possible for two files to contain the same content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc'ed in followup.

ToddGrun
ToddGrun reviewed Jun 14, 2024
View reviewed changes
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState_Checksum.cs
@@ -5,6 +5,7 @@
#nullable disable

using System;
using System.Collections.Immutable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How has a nullable disabled lasted this long in this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in followup.

@CyrusNajmabadi CyrusNajmabadi deleted the interceptsLocationWork branch June 14, 2024 15:46
This was referenced Jun 18, 2024
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz