Fix flakiness in LSP references tests due to non-deterministic ordering #74014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
dibarbet
force-pushed
the
fix_lsp_references_flakiness
branch
from
4853401 to
b77ed2e
Compare
dibarbet
commented
Jun 14, 2024
| AssertLocationsEqual(testLspServer.GetLocations("reference"), results.Select(result => result.Location)); | ||
|
|
||
| // Results are returned in a non-deterministic order, so we order them by location |
There was a problem hiding this comment.
moved all the ordering into the helper so anyone calling it gets deterministic behavior.
CyrusNajmabadi
approved these changes
Jun 14, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74009