Create new AsyncServiceProvider instead of using AsyncServiceProvider.GlobalProvider #74084
Conversation
….GlobalProvider AsyncServiceProvider.GlobalProvider is no longer an instance of AsyncServiceProvider, so the original code is failing.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -455,7 +456,7 @@ public async Task<ImmutableArray<string>> GetF1KeywordsAsync(CancellationToken c | |||
| ErrorHandler.ThrowOnFailure(vsView.GetBuffer(out var textLines)); | |||
| ErrorHandler.ThrowOnFailure(textLines.GetLanguageServiceID(out var languageServiceGuid)); | |||
|
|
|||
| var languageService = await ((AsyncServiceProvider)AsyncServiceProvider.GlobalProvider).QueryServiceAsync(languageServiceGuid).WithCancellation(cancellationToken); | |||
| var languageService = await new AsyncServiceProvider((COMAsyncServiceProvider.IAsyncServiceProvider)AsyncServiceProvider.GlobalProvider).QueryServiceAsync(languageServiceGuid).WithCancellation(cancellationToken); | |||
There was a problem hiding this comment.
As this is a fix for a downcast that wasn't documented to succeed, maybe your fix should avoid doing the same thing again. I believe the only supported way to get the COM IAsyncServiceProvider is by querying for it.
There was a problem hiding this comment.
Querying for it is easy enough. Do you know which service interface matches it?
There was a problem hiding this comment.
There isn't a different service interface for it. So it would look like this:
AsyncServiceProvider.GlobalProvider.GetService<COMAsyncServiceProvider.IAsyncServiceProvider>()You'll have to test it though. This is all based on my recollection.
There was a problem hiding this comment.
➡️ I'll submit it as a separate follow-up PR since the current one already passed integration tests.
There was a problem hiding this comment.
Yeah that will "work" as the managed version implements the native interface, but the right change is to query it as suggested by Andrew.
AsyncServiceProvider.GlobalProvideris no longer an instance ofAsyncServiceProvider, so the original code is failing.