Fix 'invert if' refactor to properly enclose #region/#endregion blocks #74145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
src/Features/Core/Portable/InvertIf/AbstractInvertIfCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| """); | ||
| } |
There was a problem hiding this comment.
can you have a test where the parent scope is a case block in a switch?
also a test where we're inverting an if-statement as a top level statement?
There was a problem hiding this comment.
I added the switch case test 😃.
I also checked for the top level if-statement but the refactor is not suggested. Am i missing something?
|
This looks good. Just would like some extra tests. Thanks! |
|
Thanks for the review @CyrusNajmabadi 😄. I'll follow your suggestions ASAP. |
3 tasks
Open
3 tasks
CyrusNajmabadi
approved these changes
Jan 20, 2025
|
Thanks! |
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #73917
Context:
While this fix targets a specific case (InvertIfStyle.IfWithoutElse_MoveSubsequentStatementsToIfBody) of GetRootWithInvertIfStatement(), it's likely that similar issues exist in other cases within this method. As I'm new to the repository i wanted to start with this specific case to ensure the approach is correct before making broader changes.