Remove some vestiges of the old solution crawler. #74239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jul 2, 2024
| shutdownToken) | ||
| { | ||
| _event = new SemaphoreSlim(initialCount: 0); | ||
| _workQueue = new AsyncBatchingWorkQueue( |
Member
Author
There was a problem hiding this comment.
instead of all this complex logic to say "wait a couple of minutes to report remote telemetry", now we just report it every 2 minutes like before.
CyrusNajmabadi
commented
Jul 2, 2024
| _workQueue = new AsyncBatchingWorkQueue( | ||
| TimeSpan.FromMinutes(2), | ||
| ProcessWorkAsync, | ||
| AsynchronousOperationListenerProvider.NullListener, |
Member
Author
There was a problem hiding this comment.
don't love this. but it's the same as the listener we used before.
ToddGrun
approved these changes
Jul 2, 2024
3 tasks
This was referenced Jul 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an overwrought system from solution-crawler to allow the host to tell the remote side "now's an ok time to do bg work". But we already have reasonable ways to do work in the BG in oop. So we can just use that instead.