Increase driver cache size #74431
Merged
Increase driver cache size #74431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase driver cache max size to 100 - Only cache a project if it actually produced generated documents
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Open
3 tasks
|
@dotnet/roslyn-compiler @jaredpar for review please :) |
333fred
approved these changes
Jul 23, 2024
jjonescz
approved these changes
Jul 24, 2024
src/Compilers/Core/Portable/SourceGeneration/GeneratorDriverCache.cs
Outdated
Show resolved
Hide resolved
| // to calculate that nothing needed to be generated, real world usage has found that generators are generally only | ||
| // expensive when actually producing source. By only caching those with results, we help to keep memory usage down | ||
| // when it probably wouldn't improve the performance anyway. | ||
| if (!disableCache && driver.GetRunResult().GeneratedTrees.Any()) |
There was a problem hiding this comment.
I'm curious about this - caching empty results increases memory usage? Shouldn't empty results be small?
There was a problem hiding this comment.
What is the ballpark for how much the cache costs in terms of memory usage?
There was a problem hiding this comment.
The driver holds onto copies of things like the Compilation, as well as all the intermediate nodes + state tables. So even if it doesn't produce anything, with enough files it can be a non-trivial amount of state.
jaredpar
reviewed
Jul 24, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ups the size of the generator cache based on observed 'big' projects in the wild. We also only cache a generator driver if it actually produced any results, based on observations that its generally fast to produce nothing.
Also updates the replay tool to support multiple iterations for testing scenarios like this (second commit)