Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report project load events for initial load in VSCode #74688

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 8, 2024

This was requested to match how VS and DevKit report project load telemetry (once when the solution is opened). Before we would report the event every time the project loaded or reloaded.

This does mean we do not report telemetry when things like the TFM change, but that is known and expected.

Verified in VSCode that the initial event is reported and changes to the project to not trigger the event to be fired.

@dibarbet dibarbet requested a review from a team as a code owner August 8, 2024 21:21
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 8, 2024
@dibarbet dibarbet changed the title Only report project load events for initial load Only report project load events for initial load in VSCode Aug 8, 2024
@dibarbet
Copy link
Member Author

dibarbet commented Aug 8, 2024

@JoeRobich probably not as important given the usage numbers, but O# should be updated to have the same behavior here.

@dibarbet dibarbet merged commit c098e96 into dotnet:main Aug 8, 2024
25 checks passed
@dibarbet dibarbet deleted the project_load_telemetry branch August 8, 2024 23:16
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 8, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants