Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file watchers for analyzer references #74745

Merged
merged 39 commits into from
Aug 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f302c7f
Move event
CyrusNajmabadi Aug 13, 2024
5de8509
Break out logic
CyrusNajmabadi Aug 13, 2024
4041b78
Simplify
CyrusNajmabadi Aug 13, 2024
425926c
rename
CyrusNajmabadi Aug 13, 2024
67397d5
no warning
CyrusNajmabadi Aug 13, 2024
44ceb61
in progress
CyrusNajmabadi Aug 13, 2024
401b557
in progress
CyrusNajmabadi Aug 13, 2024
b19e226
in progress
CyrusNajmabadi Aug 13, 2024
b9a8a80
Fix
CyrusNajmabadi Aug 13, 2024
7b1949b
Formatting
CyrusNajmabadi Aug 13, 2024
4a688d0
Merge branch 'removeAnalyzerReferenceType' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
3bdd9a3
reorder
CyrusNajmabadi Aug 13, 2024
ad7ab9a
Simplify
CyrusNajmabadi Aug 13, 2024
187d1d9
Fall out
CyrusNajmabadi Aug 13, 2024
1d02e12
in progress
CyrusNajmabadi Aug 13, 2024
f1ec2d2
Merge branch 'useImmutableArray' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
fa2d562
Merge branch 'renames' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
facf648
Merge branch 'avoidAsyncVoid' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
70740b2
Merge branch 'foreachNonVar' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
a000ba3
Merge branch 'avoidAsyncVoid' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
61df485
back to one file
CyrusNajmabadi Aug 13, 2024
2a303b4
Factories
CyrusNajmabadi Aug 13, 2024
5f77496
limit to AnalyzerFileReferences
CyrusNajmabadi Aug 13, 2024
838b9bc
share code
CyrusNajmabadi Aug 13, 2024
16af506
docs
CyrusNajmabadi Aug 13, 2024
d6fd5e5
Update src/Workspaces/Core/Portable/Workspace/ProjectSystem/FileWatch…
CyrusNajmabadi Aug 13, 2024
5aaa481
Merge remote-tracking branch 'upstream/main' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
b00f00c
Merge branch 'usePrimaryConstructor2' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
36a9e76
Merge branch 'usePrimaryConstructor2' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
af6ba08
rename back
CyrusNajmabadi Aug 13, 2024
18a60e9
Merge branch 'simplifyPropertyAccess' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
148a348
docs
CyrusNajmabadi Aug 13, 2024
7b8f050
Merge remote-tracking branch 'upstream/main' into analyzerFileWatching
CyrusNajmabadi Aug 13, 2024
0b522fe
Merge branch 'main' into analyzerFileWatching
CyrusNajmabadi Aug 14, 2024
4f9fc23
Merge remote-tracking branch 'upstream/main' into analyzerFileWatching
CyrusNajmabadi Aug 14, 2024
3a01d60
Merge remote-tracking branch 'upstream/main' into analyzerFileWatching
CyrusNajmabadi Aug 14, 2024
02b7a76
Named args
CyrusNajmabadi Aug 14, 2024
eb45459
Simplify
CyrusNajmabadi Aug 15, 2024
b9ac5e7
Merge remote-tracking branch 'upstream/main' into analyzerFileWatching
CyrusNajmabadi Aug 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fall out
CyrusNajmabadi committed Aug 13, 2024
commit 187d1d952ea0c773e667c4e690bb696354a7c0de
Original file line number Diff line number Diff line change
@@ -43,14 +43,12 @@ public LoadedProject(ProjectSystemProject projectSystemProject, SolutionServices
// We'll watch the directory for all source file changes
// TODO: we only should listen for add/removals here, but we can't specify such a filter now
var projectDirectory = Path.GetDirectoryName(projectSystemProject.FilePath)!;
var watchedDirectories = new WatchedDirectory[]
{

_fileChangeContext = fileWatcher.CreateContext([
new(projectDirectory, ".cs"),
new(projectDirectory, ".cshtml"),
new(projectDirectory, ".razor")
};

_fileChangeContext = fileWatcher.CreateContext(watchedDirectories);
]);
_fileChangeContext.FileChanged += FileChangedContext_FileChanged;

// Start watching for file changes for the project file as well