-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move net451 test assets to net461 #74766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Aug 15, 2024
This was referenced Aug 15, 2024
Open
3 tasks
@dotnet/roslyn-compiler PTAL |
cston
reviewed
Aug 16, 2024
src/Compilers/CSharp/Test/Emit2/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Aug 16, 2024
333fred
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot checked a number of the files in the PR, and went through the test helper classes. Going to sign off overall.
cston
approved these changes
Aug 17, 2024
Integration test failures are unrelated |
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates our tests which depended on
net451
assemblies to usenet461
assemblies instead. The reason for this is to consolidate our test assets to make them easier to manager. This also saves 127MB of disk I/O when doing a restore in CI which should reduce PR validation time. The under pinning mentality of this change is thatnet451
andnet461
are not significantly different hence this update should be very straight forward.This PR is broken into two commits. The first commit is a mostly mechanical migration from
net451
tonet461
. There are a number of places where I had to do minor fixups in baselines like changingSystem.dll(net451)
toSystem(net461)
. The only significant functional issue that popped up reading through the tests is a number ofnet451
tests depended onArray.Empty<T>
not existing. Those required functional changes to work: typically by usingMakeMemberMissing
calls to maintain the behavior. To help reviewing these are the tests impacted by this behavior.CodeGenExprLambdaTests.MethodCallWithParams
CollectionExpressionTests.ArrayEmpty_01
CollectionExpressionTests.ArrayEmpty_02
InternalsVisibleToAndStrongNameTests.IvtVirtualCall1
InternalsVisibleToAndStrongNameTests.IvtVirtualCall2
MissingSpecialMember.AllSpecialTypeMembers
Note: Had to temporarily disable BC30645ERR_InvalidOptionalParameterUsage1b. Will re-enable that test once I can publish to nuget.org again, fix the ref assembly bug that will let me port this test to
net461
The second commit is refactor rename of various APIs that had the part
WithMscorlib45
toWithMscorlib461
. Suggest mostly spot checking that one.