Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug-only assert method #74996

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

333fred
Copy link
Member

@333fred 333fred commented Sep 4, 2024

This method is only used in one place, only wraps one method call, and can cause people to accidentally select the wrong method in RELEASE mode. I've just inlined the content and removed the method.

This method is only used in one place, only wraps one method call, and can cause people to accidentally select the wrong method in RELEASE mode. I've just inlined the content and removed the method.
@333fred 333fred requested a review from a team as a code owner September 4, 2024 23:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 4, 2024
@333fred
Copy link
Member Author

333fred commented Sep 4, 2024

@dotnet/roslyn-compiler for a small review.

@333fred
Copy link
Member Author

333fred commented Sep 4, 2024

@dotnet/roslyn-compiler for a second small review.

@jaredpar jaredpar added this to the 17.12 milestone Sep 5, 2024
@333fred 333fred merged commit 8ce8103 into dotnet:main Sep 5, 2024
24 checks passed
@333fred 333fred deleted the overload-refactor branch September 5, 2024 21:29
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.12, Next Sep 5, 2024
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants