Report source generator failures in Hot Reload diagnostics #75029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Interactive
untriaged
|
@davidwengier PTAL |
davidwengier
approved these changes
Sep 10, 2024
src/Features/Core/Portable/EditAndContinue/EmitSolutionUpdateResults.cs
Outdated
Show resolved
Hide resolved
…esults.cs Co-authored-by: David Wengier <david.wengier@microsoft.com>
This was referenced Sep 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VS source generator diagnostics are reported by the IDE in the Error List. However, in balanced mode these might not be immediately reported. If Hot Reload is invoked before these diagnostics are reported the user wouldn't know why Hot Reload failed unless the diagnostics are included in Hot Reload output.
dotnet-watch also needs to see these diagnostics in the output of GetUpdatesAsync in order to report them.
The second commit fixes translation of
DiagnostictoDiagnosticData. The translation requires Solution snapshot to look up diagnostic locations by syntax tree. It needs to use the snapshot that has source-generated files all up-to-date, otherwise it won't be able to find the documents references by the diagnostic and produces project-level diagnostics instead.Fixes #70863 and https://github.com/dotnet/AspNetCore-ManualTests/issues/3080