Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge features/field-keyword into main #75228

Merged
merged 26 commits into from
Sep 25, 2024
Merged

Merge features/field-keyword into main #75228

merged 26 commits into from
Sep 25, 2024

Conversation

cston
Copy link
Member

@cston cston commented Sep 25, 2024 •
edited
Loading

cston and others added 26 commits August 1, 2024 13:17
@cston
Parse field as a contextual keyword (dotnet#73947)
a55ed9c
@CyrusNajmabadi @cston @RikkiGibson
Update 'use auto property' to support using the field keyword (dotn…
4111c76 
…et#74629)

Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com>
Co-authored-by: Rikki Gibson <rigibson@microsoft.com>
@cston
Handle various cases for field-backed properties (dotnet#74641)
2397d0d
@cston
Report field diagnostic as warning, only report when ambiguous, and o…
2b39f49 
…nly with preview language version (dotnet#74729)
@CyrusNajmabadi
Move feature to only working when in 'Preview'
a878dd2
@CyrusNajmabadi
Update tests
c01a6bc
@CyrusNajmabadi
Merge pull request dotnet#74886 from CyrusNajmabadi/analyzerPreview
1b4bb82
@cston @333fred
Field-backed properties: update uses of IsAutoProperty (dotnet#74798)
b8c1ea0 
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
@cston
Field-backed properties: readonly backing field (dotnet#74922)
10f9b1e
@CyrusNajmabadi
Merge branch 'main' into mergeMainIntoField
a4aa0b7
@CyrusNajmabadi
Merge remote-tracking branch 'upstream/main' into mergeMainIntoField
a68093b
@CyrusNajmabadi
Add 'field' keyword recommender
a61e789 
Add test

Add test
@CyrusNajmabadi
Docs
17c6298
@CyrusNajmabadi
Simplify
fbb9634
@CyrusNajmabadi
Fixes
e9152c0
@CyrusNajmabadi
Simplify
62270ae
@CyrusNajmabadi
Add tests
d4a3602
@CyrusNajmabadi
classification
ea16097
@CyrusNajmabadi
Merge pull request dotnet#74955 from CyrusNajmabadi/mergeMainIntoField
9ab0ffe
@CyrusNajmabadi
Merge pull request dotnet#74956 from CyrusNajmabadi/recommendField2
08b50e8
@cston
Field-backed properties: support partial properties with auto-impleme…
3bfa347 
…nted accessors and with initializers (dotnet#74959)
@cston
Field-backed properties: definite assignment (dotnet#75116)
5aceebc
@cston
Merge remote-tracking branch 'upstream/main' into features/field-keyword
09052a0
@cston
Merge pull request dotnet#75227 from cston/field-merge-main
2bb756e 
Merge main into features/field-keyword
@cston
Field-backed properties: interface properties (dotnet#75219)
f1b2823
@cston
Merge remote-tracking branch 'upstream/features/field-keyword' into main
1c00142
@cston cston requested review from a team as code owners September 25, 2024 02:53
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 25, 2024
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Sep 25, 2024
@cston cston requested a review from jaredpar September 25, 2024 02:56
@RikkiGibson RikkiGibson removed the request for review from a team September 25, 2024 20:29
@cston cston merged commit bdebb57 into dotnet:main Sep 25, 2024
28 checks passed
@cston cston deleted the merge-field-keyword branch September 25, 2024 21:21
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 25, 2024
@akhera99 akhera99 modified the milestones: Next, 17.12 P3 Sep 26, 2024
This was referenced Sep 27, 2024
Closed
Closed
@jnm2 jnm2 mentioned this pull request Sep 27, 2024
Closed
This was referenced Sep 27, 2024
Closed
Closed
@BillWagner BillWagner mentioned this pull request Oct 3, 2024
Closed
5 tasks
@RikkiGibson RikkiGibson mentioned this pull request Nov 12, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Compilers Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.12 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@cston @jaredpar @akhera99 @CyrusNajmabadi