Fix crash in 'use collection initializer' #75242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Sep 25, 2024
| @@ -94,8 +93,35 @@ public AbstractSpeculationAnalyzer( | |||
| } | |||
|
|
|||
| protected abstract ISyntaxFacts SyntaxFactsService { get; } | |||
|
|
|||
| protected abstract SyntaxNode GetSemanticRootForSpeculation(TExpressionSyntax expression); | |||
There was a problem hiding this comment.
just moved all the abstract methods to the top of the file.
CyrusNajmabadi
commented
Sep 25, 2024
| protected abstract TExpressionSyntax GetForEachStatementExpression(TForEachStatementSyntax forEachStatement); | ||
| protected abstract bool IsForEachTypeInferred(TForEachStatementSyntax forEachStatement, SemanticModel semanticModel); | ||
| protected abstract bool ForEachConversionsAreCompatible(SemanticModel originalModel, TForEachStatementSyntax originalForEach, SemanticModel newModel, TForEachStatementSyntax newForEach); | ||
| protected abstract void GetForEachSymbols( |
There was a problem hiding this comment.
this method changed to add more information back.
CyrusNajmabadi
commented
Sep 25, 2024
| Dim info = model.GetForEachStatementInfo(forEach) | ||
| getEnumeratorMethod = info.GetEnumeratorMethod | ||
| elementType = info.ElementType | ||
| localVariables = ImmutableArray.Create(DirectCast(model.GetDeclaredSymbol(forEach), ILocalSymbol)) |
There was a problem hiding this comment.
always safe in VB. it doesn't have deconstructions in foreach statements.
Open
3 tasks
|
@akhera99 ptal :) |
akhera99
approved these changes
Sep 26, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75214