Make types in Workspace layer sealed #75321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Oct 1, 2024
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.FindSymbols; | |||
|
|
|||
| internal partial class AbstractSyntaxIndex<TIndex> | |||
| internal abstract partial class AbstractSyntaxIndex<TIndex> | |||
There was a problem hiding this comment.
partial abstract types had all their parts updated to be 'abstract' to make it easy to see thast this is abstract (and not accidentally seal it). Same with partial statics.
CyrusNajmabadi
force-pushed
the
makeSealed
branch
from
c28c8f4 to
9ab6a2f
Compare
CyrusNajmabadi
force-pushed
the
makeSealed
branch
from
9ab6a2f to
2bb413e
Compare
Open
3 tasks
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.