Build and publish .ni.pdb for R2R images #75489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
genlu
reviewed
Oct 11, 2024
| Condition="'$(GenerateReadyToRun)' == 'true'"> | ||
|
|
||
| <MakeDir Directories="$(ArtifactsNonShippingPackagesDir)" /> | ||
| <ZipDirectory SourceDirectory="$(PdbWorkDir)" DestinationFile="$(ArtifactsNonShippingPackagesDir)$(ProjectName).symbols.nupkg" /> |
There was a problem hiding this comment.
I thought the fix would be much complicated than that, thanks! By the way how did you figured this out? Is there any documents related to this?
There was a problem hiding this comment.
Arcade is publishing symbol packages here: https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L89
Typically a symbol package is created by nuget, but I think just zipping up the files might also work. I don't think arcade publishing specifically needs a nuget package, just a zip container.
genlu
approved these changes
Oct 11, 2024
arunchndr
approved these changes
Oct 11, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.