ClrOnly condition is not working on mono #75548
Conversation
The functionality work both on little endian and bigendian architecture. Hence removing the assert statements. These can be verified by running CommandLine test suite.
Couple of visualBasic "EmitAndContinue" test cases fail with "Operation is not supported on this platform" error. Reason for these failure is that they are not supported on Mono. Ensured that these test cases are skipped when run on mono.
This reverts commit 534273d.
Couple of visualBasic "EmitAndContinue" test cases fail with "Operation is not supported on this platform" error. Reason for these failure is that they are not supported on Mono. Ensured that these test cases are skipped when run on mono.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
|
r/azp |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 75548 in repo dotnet/roslyn |
|
@jjonescz Can you please restart azure pipeline. This was failing due to dependency with previous commit. |
|
\cc @uweigand |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@jjonescz Thanks for running the AZP. Would you mind reviewing the changes ? |
| @@ -373,7 +373,7 @@ static ImmutableArray<INamedTypeSymbol> getForwardedTypes(AssemblySymbol assembl | |||
| } | |||
| } | |||
|
|
|||
| [ConditionalFact(typeof(ClrOnly), Reason = "Static execution is runtime defined and this tests Clr behavior only")] | |||
| [ConditionalFact(typeof(NotOnMonoCore), Reason = "Static execution is runtime defined and this tests Clr behavior only")] | |||
There was a problem hiding this comment.
With NotOnMonoCore, the test would get executed on Mono Desktop, right? But it presumably wouldn't work there since it used to be marked ClrOnly. So should we use CoreClrOnly instead?
There was a problem hiding this comment.
Hi, with "CoreClrOnly", the test fails.
There was a problem hiding this comment.
Oh, right, is that because ExecutionConditionUtil.IsCoreClr is true when running on mono core?
Well, still, we want to skip this test on both MonoCore and MonoDesktop, don't we? Perhaps we should have a NotOnAnyMono attribute?
There was a problem hiding this comment.
Yes you are right . IsCoreClr is just a negation of IsDesktop which just check "RuntimeUtilities.IsDesktopRuntime" which is true when running on mono core.
yes, We should have NotOnAnyMono attribute. Will make these changes .
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
|
Hi @jjonescz , Can this be merged ? |
|
Thanks @giritrivedi for the contribution |
This test case tests the Clr behaviour Only. ConditionalFact(typeof(ClrOnly) should skip the execution of the test case if it is executed on Mono. However, the condition doesn't hold good.
The fix takes care of skipping the execution tests on Mono which are meant for ClrOnly.