Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncrementalBinder - properly bind else-if statement #75579

Merged
merged 2 commits into from
Oct 23, 2024
Merged

IncrementalBinder - properly bind else-if statement #75579

merged 2 commits into from
Oct 23, 2024

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Oct 22, 2024 •
edited
Loading

This is a follow up on #74317

@AlekseyTs AlekseyTs requested a review from a team as a code owner October 22, 2024 13:48
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 22, 2024
@AlekseyTs AlekseyTs requested a review from cston October 22, 2024 13:49
cston
cston reviewed Oct 22, 2024
View reviewed changes
src/Compilers/CSharp/Portable/Compilation/MemberSemanticModel.cs
if (alternative is not null)
{
Debug.Assert(alternative is BoundIfStatement);
alternative = WrapWithVariablesIfAny(node, alternative);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative = WrapWithVariablesIfAny(node, alternative);

Do the tests demonstrate the effect of this line? (It looks like the added tests succeed without this.)

@AlekseyTs AlekseyTs requested a review from cston October 22, 2024 18:06
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

@AlekseyTs AlekseyTs merged commit bc89495 into dotnet:main Oct 23, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 23, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
This was referenced Oct 29, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekseyTs @333fred @cston @akhera99