Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on fixes in runtime (enable execution of affected scenarios) #75670

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Follow up on fixes in runtime (enable execution of affected scenarios) #75670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/Compilers/CSharp/Test/Symbol/Symbols/DefaultInterfaceImplementationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,25 +51,13 @@ private static Verification VerifyOnMonoOrCoreClr

private static Verification Verify(bool isStatic)
{
// IL Verify complains about static constrained calls: "Missing callvirt following constrained prefix."
return isStatic ? Verification.Skipped : VerifyOnMonoOrCoreClr;
}

private static bool Execute(bool isStatic, bool haveImplementationInDerivedInterface = false, bool hasImplementationOfVirtualInDerivedType = false)
{
// The runtime ignores the implementation of a static virtual method in derived types
// Tracked by https://github.com/dotnet/roslyn/issues/64501
if (isStatic && hasImplementationOfVirtualInDerivedType)
{
return false;
}

// https://github.com/dotnet/roslyn/issues/61321 : Enable execution for isStatic and haveImplementationInDerivedInterface once runtime can handle it.
if (!ExecutionConditionUtil.IsMonoOrCoreClr || (isStatic && haveImplementationInDerivedInterface))
{
return false;
}

return true;
return ExecutionConditionUtil.IsMonoOrCoreClr;
}

private static Verification VerifyOnMonoOrCoreClr_FailsIlVerify
Expand Down