Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VBCSCompiler pipe name insensitive to casing of the path #75852

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Make VBCSCompiler pipe name insensitive to casing of the path #75852

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7ae951
Make VBCSCompiler pipe name insensitive to casing of the path
jjonescz Nov 11, 2024
8280879
Improve comment wording
jjonescz Nov 12, 2024
17b8020
Merge branch 'main' into 75714-PipeName
jjonescz Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Compilers/Server/VBCSCompilerTests/BuildClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,14 @@ public void GetPipeNameForPathOptLength()
// We only have ~50 total bytes to work with on mac, so the base path must be small
Assert.Equal(43, name.Length);
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/75714")]
public void GetPipeNameForPath_Casing()
{
var path1 = string.Format(@"q:{0}the{0}path", Path.DirectorySeparatorChar);
var path2 = string.Format(@"Q:{0}The{0}Path", Path.DirectorySeparatorChar);
Assert.Equal(BuildServerConnection.GetPipeName(path1), BuildServerConnection.GetPipeName(path2));
}
}
}
}
3 changes: 3 additions & 0 deletions src/Compilers/Shared/BuildServerConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,9 @@ internal static string GetPipeName(
// of this method.
clientDirectory = clientDirectory.TrimEnd(Path.DirectorySeparatorChar);

// Similarly, we don't want multiple servers if the path differs in casing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that applicable only on Windows?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any OS can have case insensitive paths, or even paths for which parts have case insensitivity.

jjonescz marked this conversation as resolved.
Show resolved Hide resolved
clientDirectory = clientDirectory.ToLowerInvariant();

var pipeNameInput = $"{userName}.{isAdmin}.{clientDirectory}";
using (var sha = SHA256.Create())
{
Expand Down
Loading