Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve goto-def on an invalid override #75901

Merged
merged 3 commits into from
Nov 14, 2024
Merged

improve goto-def on an invalid override #75901

merged 3 commits into from
Nov 14, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #57110

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 13, 2024 21:52
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 13, 2024
dibarbet
dibarbet reviewed Nov 13, 2024
View reviewed changes
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ITypeSymbolExtensions.cs Outdated
{
yield return current;
current = current.BaseType;
var current = type.BaseType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would type?.BaseType work here instead of the if?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. done.

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ISymbolExtensions.cs Outdated Show resolved Hide resolved
@CyrusNajmabadi CyrusNajmabadi merged commit 5c91b9d into dotnet:main Nov 14, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the goToOverrideLoose branch November 14, 2024 00:52
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 14, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 14, 2024
Merged
This was referenced Nov 17, 2024
Closed
Closed
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.

Go To Base/Implementation should be more flexible when signatures do not match
3 participants
@CyrusNajmabadi @dibarbet @jjonescz