Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the cases that 'simplify linq' works on #76079

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Improve the cases that 'simplify linq' works on #76079

merged 1 commit into from
Nov 25, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #71293

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 25, 2024 21:04
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 25, 2024
ToddGrun
ToddGrun reviewed Nov 25, 2024
View reviewed changes
src/Workspaces/CSharp/Portable/CodeGeneration/CSharpSyntaxGenerator.cs
}
list.AddRange((IEnumerable<SyntaxToken>)(accessibility switch
{
Accessibility.Internal => [InternalKeyword],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessibility.Internal

I don't feel too strongly as I don't know if this is called often enough to care, but the old code was about as readable to me and didn't need the allocations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allocations here aren't an issue. this isn't aclled in any sort of hot loop.

ToddGrun
ToddGrun approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit fec0a94 into dotnet:main Nov 25, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 25, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the simplifyLinq branch November 25, 2024 23:25
@dotnet-bot dotnet-bot mentioned this pull request Nov 29, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

IDE0120 does not work in various cases (Where+Count)
2 participants
@CyrusNajmabadi @ToddGrun