Update regex parsing to latest .Net core parsing (and diagnostic messages). #76269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
3 tasks
CyrusNajmabadi
commented
Jan 16, 2025
| { | ||
| // bug with .NET regex parser. can happen with patterns like: (?(?S)) | ||
| return treeAndText; | ||
| } |
There was a problem hiding this comment.
workarounds for when we found regex strings that would crash .net :) these have been fixed in .net core, so we don't need this.
CyrusNajmabadi
commented
Jan 16, 2025
src/EditorFeatures/CSharpTest2/Microsoft.CodeAnalysis.CSharp.EditorFeatures2.UnitTests.csproj
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jan 16, 2025
| @@ -1093,14 +1064,14 @@ internal abstract class RegexConditionalGroupingNode : RegexQuestionGroupingNode | |||
| { | |||
| protected RegexConditionalGroupingNode( | |||
| RegexKind kind, RegexToken openParenToken, RegexToken questionToken, | |||
| RegexExpressionNode result, RegexToken closeParenToken) | |||
| RegexAlternationNode result, RegexToken closeParenToken) | |||
There was a problem hiding this comment.
made more strongly typed.
JoeRobich
reviewed
Jan 16, 2025
| <PropertyGroup> | ||
| <StartupObject /> | ||
| <TargetFramework>net472</TargetFramework> | ||
| <UseWpf>true</UseWpf> | ||
| <TargetFrameworks>$(NetRoslyn)</TargetFrameworks> |
CyrusNajmabadi
commented
Jan 16, 2025
| // From the .NET regex code: | ||
| // This is code for Posix style properties - [:Ll:] or [:IsTibetan:]. | ||
| // It currently doesn't do anything other than skip the whole thing! | ||
| if (!afterRangeMinus && _currentToken.Kind == RegexKind.OpenBracketToken && _lexer.IsAt(":")) |
There was a problem hiding this comment.
rmoved in dotnet/runtime#88590
CyrusNajmabadi
commented
Jan 16, 2025
| var optionsToken = _lexer.TryScanOptions(); | ||
| if (optionsToken != null) | ||
| // Corresponds to check at: https://github.com/dotnet/runtime/blob/7790117932dc14aaeb2fc82aff6c0dc6c74ce434/src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexParser.cs#L1003 | ||
| if (!inConditionalExpression) |
There was a problem hiding this comment.
Changed in dotnet/corefx#16609
CyrusNajmabadi
changed the title
JoeRobich
approved these changes
Jan 16, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61215