Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nullable postcondition for non-static local function inside field initializer #76716

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

RikkiGibson
Copy link
Contributor

Closes #76528

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 10, 2025
@RikkiGibson RikkiGibson marked this pull request as ready for review January 11, 2025 16:38
@RikkiGibson RikkiGibson requested a review from a team as a code owner January 11, 2025 16:38
{
public static string? field;

public Action Prop1 { get; } = () =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider testing also when the lambdas are marked static.

@RikkiGibson RikkiGibson requested a review from a team January 14, 2025 23:43
@RikkiGibson
Copy link
Contributor Author

@dotnet/roslyn-compiler for second review

@jcouv jcouv self-assigned this Jan 17, 2025
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 2)

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 7)

@jcouv jcouv removed their assignment Feb 4, 2025
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 8)

@akhera99 akhera99 modified the milestones: Next, 17.14 P2 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
5 participants