Change helix logging #76828
Merged
Change helix logging #76828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes helix logging in a few ways: 1. Includes helix.proj in the artifacts directory for tool / developer inspection 2. Adds the expected execution time of a work item into helix.proj so it can be compared to actual execution time. The other change is more philosophical. Trying to make it so that only the structured / tooling data gets put into the artifacts dir. For any other logging that isn't structural in nature just print directly to the console so we can quickly see it at a glance
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
@dotnet/roslyn-infrastructure PTAL |
dibarbet
approved these changes
Jan 21, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes helix logging in a few ways:
The other change is more philosophical. Trying to make it so that only the structured / tooling data gets put into the artifacts dir. For any other logging that isn't structural in nature just print directly to the console so we can quickly see it at a glance