Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target test projects in Workspaces and Features layers to NetVSShared #76918

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 24, 2025

Our primary scenarios are devenv, VS OOP and VS Code, hence the tests should target net472 and net8.0.

Switching to the right TFM uncovers a bug in Semantic Search. We targeted Semantic Search references to net9.0 and tried to load the code to net8.0 OOP.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 24, 2025
@tmat tmat marked this pull request as ready for review January 25, 2025 16:31
@tmat tmat requested a review from a team as a code owner January 25, 2025 16:31
@tmat tmat changed the title Sem search tfm Target test project in Workspaces and Features layers to NetVSShared Jan 25, 2025
@tmat
Copy link
Member Author

tmat commented Jan 25, 2025

@dotnet/roslyn-ide @jaredpar ptal

@tmat tmat changed the title Target test project in Workspaces and Features layers to NetVSShared Target test projects in Workspaces and Features layers to NetVSShared Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants