System.CommandLine update #76948
Merged
System.CommandLine update #76948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild 20250121.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.607102
…uild 20250122.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.607201
ghost
added
Area-Infrastructure
untriaged
dotnet-policy-service
bot
added
Community
adamsitnik
commented
Jan 28, 2025
| // LSP server doesn't have the pieces yet to support 'balanced' mode for source-generators. Hardcode us to | ||
| // 'automatic' for now. | ||
| var globalOptionService = exportProvider.GetExportedValue<IGlobalOptionService>(); | ||
| var globalOptionService = exportProvider.GetExportedValue<Microsoft.CodeAnalysis.Options.IGlobalOptionService>(); |
Member
Author
There was a problem hiding this comment.
After removing the Cli prefix (to make sure we don't break every single System.CommandLine user), Microsoft.CodeAnalysis.Options.Option<T> conflicts with System.CommandLine.Option<T>. I decided to remove the using Microsoft.CodeAnalysis.Options line and specify full name here as other solutions would require more changes.
jjonescz
approved these changes
Jan 28, 2025
JoeRobich
approved these changes
Jan 28, 2025
This was referenced Feb 4, 2025
adamsitnik
pushed a commit
to adamsitnik/roslyn
that referenced
this pull request
Apr 14, 2025
This PR consists of dotnet#76851 (the maestro PR) and actual changes required to update S.CL. # Conflicts: # eng/Version.Details.xml # eng/Versions.props
ViktorHofer
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Update dependencies from https://github.com/dotnet/command-line-api build 20250303.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.615301 * Update dependencies from https://github.com/dotnet/command-line-api build 20250317.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.616701 * Update dependencies from https://github.com/dotnet/command-line-api build 20250318.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.616801 * Update dependencies from https://github.com/dotnet/command-line-api build 20250320.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.617001 * Update dependencies from https://github.com/dotnet/command-line-api build 20250324.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.617401 * Update dependencies from https://github.com/dotnet/command-line-api build 20250408.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.620801 * Update dependencies from https://github.com/dotnet/command-line-api build 20250409.2 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.620902 * Update dependencies from https://github.com/dotnet/command-line-api build 20250410.1 Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine From Version 0.1.552801 -> To Version 0.1.621001 * System.CommandLine update (#76948) This PR consists of #76851 (the maestro PR) and actual changes required to update S.CL. # Conflicts: # eng/Version.Details.xml # eng/Versions.props * fix the build? --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of #76851 (the maestro PR) and actual changes required to update S.CL.