Remove argument that was always passed the same value #77045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 5, 2025
| @@ -30,9 +30,8 @@ private async Task<ProjectAnalysisData> GetProjectAnalysisDataAsync( | |||
| try | |||
| { | |||
| // PERF: We need to flip this to false when we do actual diffing. | |||
| var avoidLoadingData = true; | |||
There was a problem hiding this comment.
always passing true here.
CyrusNajmabadi
commented
Feb 5, 2025
| @@ -92,15 +92,15 @@ public DiagnosticAnalysisResult GetResult(DiagnosticAnalyzer analyzer) | |||
| public bool TryGetResult(DiagnosticAnalyzer analyzer, out DiagnosticAnalysisResult result) | |||
| => Result.TryGetValue(analyzer, out result); | |||
|
|
|||
| public static async Task<ProjectAnalysisData> CreateAsync(Project project, IEnumerable<StateSet> stateSets, bool avoidLoadingData, CancellationToken cancellationToken) | |||
| public static async Task<ProjectAnalysisData> CreateAsync(Project project, ImmutableArray<StateSet> stateSets, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
always passed true into here.
CyrusNajmabadi
commented
Feb 5, 2025
| { | ||
| VersionStamp? version = null; | ||
|
|
||
| var builder = ImmutableDictionary.CreateBuilder<DiagnosticAnalyzer, DiagnosticAnalysisResult>(); | ||
| foreach (var stateSet in stateSets) | ||
| { | ||
| var state = stateSet.GetOrCreateProjectState(project.Id); | ||
| var result = await state.GetAnalysisDataAsync(project, avoidLoadingData, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
always passed true into here.
CyrusNajmabadi
commented
Feb 5, 2025
| @@ -67,7 +67,7 @@ public async Task<DiagnosticAnalysisResult> GetAnalysisDataAsync(Project project | |||
| // PERF: avoid loading data if version is not right one. | |||
| // avoid loading data flag is there as a strictly perf optimization. | |||
| var version = await GetDiagnosticVersionAsync(project, cancellationToken).ConfigureAwait(false); | |||
| if (avoidLoadingData && lastResult.Version != version) | |||
| if (lastResult.Version != version) | |||
There was a problem hiding this comment.
so this can trivially be removed.
CyrusNajmabadi
commented
Feb 5, 2025
...guageServer/Protocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
…nosticIncrementalAnalyzer.Executor.cs
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.