Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DiagnosticIncrementalAnalyzer a nested private type #77096

Merged
merged 14 commits into from
Feb 7, 2025

Conversation

CyrusNajmabadi
Copy link
Member

Followup to #77094

This is a private impl detail. It should not be exposed, and tests should not be accessing it directly. #77094 removes the bulk of the usages in tests.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner February 7, 2025 00:53
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 7, 2025
@CyrusNajmabadi CyrusNajmabadi merged commit 459efff into dotnet:main Feb 7, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the diagNestedType branch February 7, 2025 17:32
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 7, 2025
@akhera99 akhera99 modified the milestones: Next, 17.14 P2 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants