Remove nested types in diagnostic analyzer service #77124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
ToddGrun
reviewed
Feb 10, 2025
| @@ -31,12 +31,10 @@ internal interface IDiagnosticAnalyzerService | |||
| /// <summary> | |||
| /// Get diagnostics of the given diagnostic ids and/or analyzers from the given solution. all diagnostics returned | |||
CyrusNajmabadi
changed the title
|
@ToddGrun thia is ready for review. |
CyrusNajmabadi
commented
Feb 10, 2025
| bool includeLocalDocumentDiagnostics, | ||
| bool includeNonLocalDocumentDiagnostics) |
There was a problem hiding this comment.
general idea is that instead of making tehse nested types, which have to grab all this data, just to store fields, just to use in methods within the type, we just use local functions.
ToddGrun
reviewed
Feb 11, 2025
| @@ -22,7 +22,7 @@ private partial class DiagnosticIncrementalAnalyzer | |||
| /// <summary> | |||
| /// Cached data from a real <see cref="Project"/> instance to the cached diagnostic data produced by | |||
| /// <em>all</em> the analyzers for the project. This data can then be used by <see | |||
| /// cref="DiagnosticGetter.ProduceDiagnosticsAsync"/> to speed up subsequent calls through the normal <see | |||
| /// cref="GetDiagnosticsForIdsAsync"/> to speed up subsequent calls through the normal <see | |||
ToddGrun
reviewed
Feb 11, 2025
...erver/Protocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Feb 11, 2025
| public async Task GetAsync(ArrayBuilder<DiagnosticData> list, CancellationToken cancellationToken) | ||
| return list.ToImmutableAndClear(); | ||
|
|
||
| async Task GetAsync(ArrayBuilder<DiagnosticData> list) |
|
FYI, I really like this change. These *Getter classes for some reason added a lot of conceptual weight to this area for me. |
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #77122