Loosen casting requirements on switch expression conversion #77139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
Open
3 tasks
CyrusNajmabadi
approved these changes
Aug 8, 2025
Member
|
Thanks for the initial PR. I moved the fix to the right location. |
| Func<TConditionalOrSwitchExpression, ExpressionSyntax, ExpressionSyntax?> getAlternativeArm, | ||
| CancellationToken cancellationToken) | ||
| where TConditionalOrSwitchExpression : ExpressionSyntax | ||
| { |
Member
There was a problem hiding this comment.
all the logic in here is what we had in IsConditionalCastSafeToRemove, but made generic so it can operate on a a?b:c expr vs a a switch { ... } expr, with helper functions to deal with conditional exprs only having two arms, which switches can have many.
Member
|
Thannks! |
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77084
The fix for the old issue #58636 was more conservative than it needed to be. This allows eg.
boolto be returned to anobjecttarget in a switch expression arm without a cast.