Cache diagnostic info based on project state not project. #77230
+62
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@ToddGrun ptal |
ToddGrun
reviewed
Feb 14, 2025
| // | ||
| // Note: While ForceAnalyzeProjectAsync should always run with a larger set of analyzers than us | ||
| // (since it runs all analyzers), we still run a paranoia check that the analyzers we care about are | ||
| // a subset of that call so that we don't accidentally reuse results that would not correspond to | ||
| // what we are computing ourselves. | ||
| if (_projectToForceAnalysisData.TryGetValue(project, out var box) && | ||
| var checksum = await project.GetDependentChecksumAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
so, if TryGet fails, we need this data to compute and cache. If it succeed, we need it to compare with the cached value. So we always need it.
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.