Rename feature to 'Add or remove accessibility modifiers' #77234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@jasonmalinowski ptal |
jasonmalinowski
approved these changes
Feb 14, 2025
|
|
||
| internal class CSharpAddAccessibilityModifiers : AbstractAddAccessibilityModifiers<MemberDeclarationSyntax> | ||
| internal class CSharpAddOrRemoveAccessibilityModifiers : AbstractAddOrRemoveAccessibilityModifiers<MemberDeclarationSyntax> |
There was a problem hiding this comment.
We should update the file names too. Or maybe just run the fixup on our entire codebase and see what it discovers. 😄
| @@ -36,7 +36,7 @@ internal class CSharpCodeCleanupService(ICodeFixService codeFixService, IDiagnos | |||
| IDEDiagnosticIds.RemoveUnnecessaryParenthesesDiagnosticId, | |||
| IDEDiagnosticIds.AddRequiredParenthesesDiagnosticId), | |||
| new DiagnosticSet(AnalyzersResources.Add_accessibility_modifiers, | |||
There was a problem hiding this comment.
Arguably the resource could be updated too. I'm guessing this is what we show in "here's what code cleanup can do" -- so maybe it could say both, but I can also imagine if the common case is this does an add, maybe it's best to keep the text simpler.
tl;dr: feel free to do what you want here.
There was a problem hiding this comment.
there are actually two resources. so you get the precise message :)
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.