Add an option to ignore aliases when moving using directives outside a namespace #77291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 20, 2025
| @@ -56,6 +56,7 @@ public static CodeStyleOption2<AddImportPlacement> ParseUsingDirectivesPlacement | |||
| { | |||
| "inside_namespace" => new CodeStyleOption2<AddImportPlacement>(AddImportPlacement.InsideNamespace, notification), | |||
| "outside_namespace" => new CodeStyleOption2<AddImportPlacement>(AddImportPlacement.OutsideNamespace, notification), | |||
| "outside_namespace_ignoring_aliases" => new CodeStyleOption2<AddImportPlacement>(AddImportPlacement.OutsideNamespaceIgnoringAliases, notification), | |||
There was a problem hiding this comment.
intentionally using hte word ignoring (as opposed to excluding or except) as i don't want to convey taht aliases must then be required to be inside the namespace. Instead, this is trying to say that aliases are simply ignored and can appear either outside or inside the namespace (for example, roslyn follows this model).
|
@jasonmalinowski ptal. |
JoeRobich
approved these changes
Feb 20, 2025
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43271