Adds 💡 Implement Using Copilot for NotImplementedException
#77299
+1,608
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see test below
```
[InlineData("int myField;", typeof(FieldDeclarationSyntax))]
public async Task TestInvalidNodeReplacement(string syntax, Type type)
```
Open
3 tasks
src/Features/CSharp/Portable/Copilot/CSharpImplementNotImplementedExceptionFixProvider.cs
Show resolved
Hide resolved
src/Features/CSharp/Portable/Copilot/CSharpImplementNotImplementedExceptionFixProvider.cs
Outdated
Show resolved
Hide resolved
...Features/CSharpTest/Copilot/CSharpImplementNotImplementedExceptionDiagnosticAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
| @@ -70,6 +70,9 @@ public Test() | |||
| [StringSyntax(PredefinedEmbeddedLanguageNames.CSharpTest)] | |||
| public new string FixedCode { set => base.FixedCode = value; } | |||
|
|
|||
| [StringSyntax(PredefinedEmbeddedLanguageNames.CSharpTest)] | |||
| public new string BatchFixedCode { set => base.BatchFixedCode = value; } | |||
There was a problem hiding this comment.
@sharwell to check on this. curious why we haven't needed this yet.
There was a problem hiding this comment.
It's been around for a long time. It's needed for cases where Fix All in Document does not produce the same result as running the individual fixes in sequence.
CyrusNajmabadi
approved these changes
Mar 12, 2025
This was referenced Mar 12, 2025
| { | ||
| Contract.ThrowIfTrue(string.IsNullOrWhiteSpace(implementationDetails.Message)); | ||
| replacement = AddErrorComment(methodOrProperty, implementationDetails.Message); | ||
| } |
|
I don't seem to have merge privileges on roslyn repo. I'll need help with merging PR once CI is complete |
This was referenced Mar 14, 2025
| @@ -16,6 +16,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup Label="Project References"> | |||
| <ProjectReference Include="..\..\..\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj" /> | |||
| <ProjectReference Include="..\..\..\Compilers\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.csproj" /> | |||
There was a problem hiding this comment.
This was not ok. @maryamariyan this has to be removed as it is a layering violation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers 💡
Implement Using CopilotwhenNotImplementedExceptionis present in code.Implement_With_Copilot_Examples.mp4