Explictly jump off the main thread before serializing data to call Razor #77321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
akhera99
approved these changes
Feb 26, 2025
arunchndr
approved these changes
Feb 26, 2025
ToddGrun
reviewed
Feb 26, 2025
| { | ||
| // The LSP server will dispose us when the server exits, but VS could decide to activate us later. | ||
| // If a new instance of the server is created, a new instance of this class will be created and the | ||
| // UIContext will already be active, so this method will be immediately called on the new instance. | ||
| if (cancellationToken.IsCancellationRequested) return; | ||
|
|
||
| await TaskScheduler.Default.SwitchTo(alwaysYield: true); |
There was a problem hiding this comment.
Oh, or maybe you just don't want to block the calling thread, even if it's a threadpool thread. I see.
There was a problem hiding this comment.
Probably not necessary in the real world, but in theory the UI context could have been activated before we got here (in future if the conditions for the context change), or we could be in VS Code (in future) and I thought getting out of the way of the LSP servers initialize handler is probably kind regardless.
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2268495 ( AB#2268495 but I don't think that works any more 😔)