Support 'view call hierarchy' on primary consstructor #77328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Feb 24, 2025
| var semanticModel = await document.GetSemanticModelAsync(cancellationToken).ConfigureAwait(false); | ||
| var symbolUnderCaret = await SymbolFinder.FindSymbolAtPositionAsync( | ||
| semanticModel, caretPosition, document.Project.Solution.Services, cancellationToken).ConfigureAwait(false); | ||
| var symbolAndProject = await FindUsagesHelpers.GetRelevantSymbolAndProjectAtPositionAsync( |
There was a problem hiding this comment.
switched to common helper that gets the symbol and does hte mapping.
CyrusNajmabadi
commented
Feb 24, 2025
|
|
||
| var point = args.TextView.Caret.Position.Point.GetPoint(args.SubjectBuffer, PositionAffinity.Predecessor); | ||
| if (point is null) | ||
| return false; |
There was a problem hiding this comment.
pulled this up as we want to do this before kicking off the async work.
CyrusNajmabadi
commented
Feb 24, 2025
| return; | ||
| } | ||
|
|
||
| var caretPosition = args.TextView.Caret.Position.BufferPosition.Position; |
There was a problem hiding this comment.
note: this was broken. we need to map the caret pos down to the subject buffer (which i now do above). otherwise projection scenarios do not work.
|
@akhera99 @JoeRobich ptal. |
JoeRobich
approved these changes
Feb 24, 2025
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77327