-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[automated] Merge branch 'main' => 'release/dev18.0' #77431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parse partial events and constructors * Update pre-existing tests * Explain why partial ctors are sometimes disallowed * Parse `partial` constructors unconditionally * Gate parsing on LangVersion * Extend tests and docs * Fix indentation * Rename combinatorial values * Test more lang versions * Parse partial events unconditionally
* Partial events and constructors: merge and check symbols * Improve code * Move partial availability check * Improve code * Fix duplicate definition diagnostic * Test different ordering * Avoid reporting diagnostic for escaped `partial` * Clarify naming of AccessorsHaveImplementation property * Add event definition accessor symbol * Improve code * Test sequence points * Test extern IL * Fix interface container diagnostics * Fix sequence points issue in the test utility * Ensure the new accessor owner is a definition
* Partial events and constructors: check differences * Improve code and tests * Complete constructor implementation part * Report error for tuple differences in constructors
* Partial events and constructors: attributes * Update pre-existing tests * Fixup expected PEVerify output * Check a flag before materializing syntax nodes * Assert that the definition part of an event doesn't have accessors * Keep pre-existing event attribute target behavior * Improve code * Add WorkItem attribute * Strengthen asserts Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> --------- Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
* Partial events and constructors: public API * Simplify code * Add more `sealed` * Add more asserts
* Partial events and constructors: IDE * Fix event keyword recommender * Fix symbol suggestions * Fixup failing tests * Fixup SymbolKey * Improve code * Use `Equal` instead of `Same` in SymbolKey tests * Extend a test * Use collection expressions Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com> --------- Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
3 tasks
jjonescz
approved these changes
Mar 5, 2025
JoeRobich
added a commit
to dotnet/roslyn-tools
that referenced
this pull request
Mar 6, 2025
The Arcade inter-branch merge GH action creates merge commits with a differently formatted message (ex. `[automated] Merge branch 'prerelease' => 'main' (#8039)`) Tested by generating PR list between Roslyn main and Roslyn release/dev18.0: *Before*: ```md ### Changes from [main](dotnet/roslyn@main) to [release/dev18.0](dotnet/roslyn@release/dev18.0): [View Complete Diff of Changes](https://github.com/dotnet/roslyn/compare/main...release/dev18.0?w=1) - [[automated] Merge branch 'main' => 'release/dev18.0' (77445)](dotnet/roslyn#77445) - [[automated] Merge branch 'main' => 'release/dev18.0' (77441)](dotnet/roslyn#77441) - [[automated] Merge branch 'main' => 'release/dev18.0' (77431)](dotnet/roslyn#77431) - [[automated] Merge branch 'main' => 'release/dev18.0' (77409)](dotnet/roslyn#77409) - [[automated] Merge branch 'main' => 'release/dev18.0' (77374)](dotnet/roslyn#77374) - [[automated] Merge branch 'main' => 'release/dev18.0' (77292)](dotnet/roslyn#77292) - [[automated] Merge branch 'main' => 'release/dev18.0' (77226)](dotnet/roslyn#77226) - [[automated] Merge branch 'main' => 'release/dev18.0' (77153)](dotnet/roslyn#77153) - [Update Versions.props for Dev18 (77138)](dotnet/roslyn#77138) ``` *After*: ```md ### Changes from [main](dotnet/roslyn@main) to [release/dev18.0](dotnet/roslyn@release/dev18.0): [View Complete Diff of Changes](https://github.com/dotnet/roslyn/compare/main...release/dev18.0?w=1) - [Update Versions.props for Dev18 (77138)](dotnet/roslyn#77138) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Infrastructure
Needs API Review
Needs to be reviewed by the API review council
untriaged
Issues and PRs which have not yet been triaged by a lead
VSCode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected changes in the main branch which have not been merged yet to release/dev18.0. I'm a robot and am configured to help you automatically keep release/dev18.0 up to date, so I've opened this PR.
This PR merges commits made on main by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-release/dev18.0'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.