Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename flyout] Fixed cropping issue on small screens #77466

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

veler
Copy link
Contributor

@veler veler commented Mar 7, 2025

Problem

Rename flyout is being cropped on small screens. The issue being that:

  1. The flyout is larger than the document's view port
  2. The flyout's left position is negative (which makes it disappear to the left).
  3. Text within the flyout doesn't wrap.

image

Solution

Basically, address all of the above:

  1. Limit the size of the flyout to the width of the document's view port.
  2. Ensure the flyout's position is always positive.
  3. Wrap text blocks.

image

@veler veler requested a review from a team as a code owner March 7, 2025 22:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 7, 2025
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. Needs UX Triage labels Mar 7, 2025
@CyrusNajmabadi CyrusNajmabadi merged commit 42dd426 into dotnet:main Mar 10, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants