Add FAR support for modern-extension parameters #77503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
CyrusNajmabadi
commented
Mar 14, 2025
3 tasks
CyrusNajmabadi
force-pushed
the
extensionFarTests2
branch
from
09e4a9f to
1cda9cc
Compare
… now" This reverts commit e3af843.
…eckConstraintsIncludingExtension
CyrusNajmabadi
changed the title
jcouv
reviewed
Mar 20, 2025
| { | ||
| public int ExtensionMethod([|T|] t) | ||
| { | ||
| return s.Length; |
Member
There was a problem hiding this comment.
nit: Consider adding a default(T) orT-typed local as well
JoeRobich
approved these changes
Mar 20, 2025
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #77502
Relates to test plan #76130