Add RuntimeAsyncMethodGenerationAttribute #77543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds control for whether to use runtime async. The flowchart is as follows: 1. The flag `System.Runtime.CompilerServices.RuntimeFeature.Async` must be present. 2. Assuming that flag is present, we look for the presence of `System.Runtime.CompilerServices.RuntimeAsyncMethodGenerationAttribute` on the method. If that attribute is present, we use the preference expressed in the attribute. The preference does not carry to nested contexts, such as local functions or lambdas. 3. If the attribute is not present, we look for `features:runtime-async=on` on the command line. If that is present, then the feature is on by default. Otherwise, the feature is off.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@jcouv @RikkiGibson for reviews please. |
RikkiGibson
approved these changes
Mar 13, 2025
Just to confirm, my understanding is that the flag will be present in .NET 10, but marked with [Experimental]. Is that correct? Refers to: src/Compilers/CSharp/Portable/Compilation/CSharpCompilation.cs:323 in cd76c3b. [](commit_id = cd76c3b, deletion_comment = False) |
That's my understanding as well. Also |
jcouv
reviewed
Mar 18, 2025
| SourceMethodSymbol { IsRuntimeAsyncEnabledInMethod: ThreeState.True } => true, | ||
| SourceMethodSymbol { IsRuntimeAsyncEnabledInMethod: ThreeState.False } => false, | ||
| _ => Feature("runtime-async") == "on" | ||
| }; |
There was a problem hiding this comment.
Let's update the compiler spec for how those three flags (runtime feature flag, compiler feature flag, method-level attribute) work together
There was a problem hiding this comment.
Will update in main after this PR.
jcouv
reviewed
Mar 18, 2025
...rs/CSharp/Portable/Symbols/Attributes/WellKnownAttributeData/MethodWellKnownAttributeData.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Mar 18, 2025
src/Compilers/CSharp/Portable/Symbols/Source/SourceMethodSymbolWithAttributes.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Mar 18, 2025
jcouv
reviewed
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds control for whether to use runtime async. The flowchart is as follows:
System.Runtime.CompilerServices.RuntimeFeature.Asyncmust be present.System.Runtime.CompilerServices.RuntimeAsyncMethodGenerationAttributeon the method. If that attribute is present, we use the preference expressed in the attribute. The preference does not carry to nested contexts, such as local functions or lambdas.features:runtime-async=onon the command line. If that is present, then the feature is on by default. Otherwise, the feature is off.Relates to test plan #75960