Add feature to convert classic extension methods to the new 'extension' form in C# 14. #77660
Conversation
ghost
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Needs API Review
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
| /// </summary> | ||
| public abstract SyntaxNode WithModifiers(SyntaxNode declaration, DeclarationModifiers modifiers); | ||
| public SyntaxNode WithModifiers(SyntaxNode declaration, DeclarationModifiers modifiers) | ||
| => WithModifiers<SyntaxNode>(declaration, modifiers); |
There was a problem hiding this comment.
this is a safe change. it is ok to replace an abstract method with a non-abstract one in a type that isn't publicly derivable. in other words, we own all the derivations and can fix them up. and all callers who are calling this method virtually will continue to work even witha non-virtual method in the same slot as before.
| => WithModifiers<SyntaxNode>(declaration, modifiers); | ||
|
|
||
| internal abstract TSyntaxNode WithModifiers<TSyntaxNode>(TSyntaxNode declaration, DeclarationModifiers modifiers) | ||
| where TSyntaxNode : SyntaxNode; |
There was a problem hiding this comment.
by having this method, we allow internal callers to be strongly typed, allowing them to have to avoid casting the return type back to the type of hte node they passed in.
CyrusNajmabadi
merged commit b798cfc
into
dotnet:features/extensions
3 participants
Looks like this:
And:
Relates to test plan #76130