Remove public facing OOP options. #77711
Conversation
ghost
added
Area-IDE
untriaged
| {"dotnet_enable_event_hook_up", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "Event Hookup")}, | ||
| {"dotnet_format_on_save", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "FormatOnSave")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "OOP64Bit")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "OOP64Bit_New")}, |
There was a problem hiding this comment.
these flags still exist as an unsupported way to opt out of these features. however, i've moved them to new regkeys so that everyone defualts into the supported state. that way someone who disabled something in the past, isn't able to reenable if they want that.
| {"dotnet_enable_event_hook_up", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "Event Hookup")}, | ||
| {"dotnet_format_on_save", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "FormatOnSave")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "OOP64Bit")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "DotnetCodeAnalysisInSeparateProcess")}, |
There was a problem hiding this comment.
these flags still exist as an unsupported way to opt out of these features. however, i've moved them to new regkeys so that everyone defualts into the supported state. that way someone who disabled something in the past, isn't able to reenable if they want that.
| SourceGeneratorExecution: globalOptions.GetOption(SourceGeneratorExecution), | ||
| ReloadChangedAnalyzerReferences: | ||
| globalOptions.GetOption(ReloadChangedAnalyzerReferences) ?? globalOptions.GetOption(ReloadChangedAnalyzerReferencesFeatureFlag), | ||
| globalOptions.GetOption(ReloadChangedAnalyzerReferences), |
There was a problem hiding this comment.
Should we just pull this entirely? Whereas the in-proc/out-of-proc can have a bit of user impact if they depend on it in obscure ways, this is only needed if we have bugs, right?
There was a problem hiding this comment.
yes. but if there is a bug, i don't mind having a reg-key to disable this if a big customer needs it.
| {"dotnet_enable_event_hook_up", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "Event Hookup")}, | ||
| {"dotnet_format_on_save", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "FormatOnSave")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "OOP64Bit")}, | ||
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "DotnetCodeAnalysisInSeparateProcess")}, |
There was a problem hiding this comment.
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "DotnetCodeAnalysisInSeparateProcess")}, | |
| {"dotnet_code_analysis_in_separate_process", new LocalUserProfileStorage(@"Roslyn\Internal\OnOff\Features", "CodeAnalysisInSeparateProcess")}, |
The "dotnet" prefix isn't really needed for the regkey since it's already Roslyn prefixed. Not worth changing if you don't have to touch this PR for some other reason but I'm generally but not sure we want to start a tradition of prefixing everything redundantly.
There was a problem hiding this comment.
do. the idea for me was to keep teh name of the value in line with the snake_cased_name. so it's all 'consistent' in that way.
CyrusNajmabadi
merged commit f518467
into
dotnet:release/dev17.15
3 participants
We will still have reg keys available if absolutely necessary. But this will no longer be a supported config as we need OOP for several core capabilities (reloading generators/analyzers, Razor, semantic search and others).