Fix copilot layering #77713
Merged
Fix copilot layering #77713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
akhera99
approved these changes
Mar 20, 2025
Contributor
|
@CyrusNajmabadi why are you updating this? I already have another PR: #77706 |
Member
Author
Because the curent code is a layering violation that breaks roslyn rules on referencing lang specific types from a lang neutral location :) |
maryamariyan
approved these changes
Mar 20, 2025
Contributor
maryamariyan
left a comment
maryamariyan
left a comment
There was a problem hiding this comment.
chatted offline, LGTM.
assuming this is correcting the violations to keep the language neutral dlls free from C# related types.
once this is merged I will update the C# specific dlls for my purposes in #77706
tmat
reviewed
Mar 20, 2025
| </PropertyGroup> | ||
| <ItemGroup Label="Project References"> | ||
| <ProjectReference Include="..\..\..\Compilers\Core\Portable\Microsoft.CodeAnalysis.csproj" /> | ||
| <ProjectReference Include="..\..\..\Compilers\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.csproj" /> |
tmat
approved these changes
Mar 20, 2025
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.