Reduce likelihood of needing a dual insertion in VS Code #77715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/Shared : will eventually be the area for all source items shared between the current EA and the new EA.Razor.Features /Features : will have an EA that is restricted to depending only on the features layer. This will help provide a way to ship a more sane EA structure for VS Code as well as reduce the likelyhood and work required for a dual insertion /EditorFeatures : contains the current EA. The project name is kept the same for now but the folder is moved. This denotes that the binary does depend on the EditorFeatures layer in Roslyn
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
CyrusNajmabadi
approved these changes
Mar 20, 2025
davidwengier
approved these changes
Mar 20, 2025
| namespace Microsoft.CodeAnalysis.ExternalAccess.Razor.Features; | ||
|
|
||
| [MetadataAttribute] | ||
| internal class RazorEndpointAttribute : LanguageServerEndpointAttribute |
There was a problem hiding this comment.
Could RazorMethodAttribute move to the shared layer?
UPDATE: Oh, I guess that would be a break because the namespace is wrong. I guess we'll just have to move over to use this in cohosting, so we can eventually remove RazorMethodAttribute, and move this to the shared project?
There was a problem hiding this comment.
I think we'll eventually want cohosting on the Features layer only right? If so I'll just leave this as is for now
There was a problem hiding this comment.
Yeah, not too sure. Fine to leave it for now, even if we move it, we don't need to change the namespace so it won't be an issue.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to not add new functional changes but instead prepare razor to be added through
--extensionin VS Code. Razor will be allowed to export endpoints and LSP services which allows for better reuse and sharing of code. It also means that Razor will no longer have an EA for Roslyn to consume and dual insertions won't be required for most VS Code changes.Razor side: dotnet/razor#11510