Cleanup how we compute and report file-content-load issues. #77880
Conversation
ghost
added
Area-IDE
untriaged
| public static bool IsWorkspaceDiagnosticAnalyzer(this DiagnosticAnalyzer analyzer) | ||
| => analyzer is DocumentDiagnosticAnalyzer | ||
| || analyzer is ProjectDiagnosticAnalyzer | ||
| || analyzer == FileContentLoadAnalyzer.Instance |
There was a problem hiding this comment.
FileContentLoadAnalyzer is just a DocumentDiagnosticAnalyzer now. so we don't need this special check.
| var document = textDocument as Document; | ||
| RoslynDebug.Assert(document != null || kind == AnalysisKind.Syntax, "We only support syntactic analysis for non-source documents"); | ||
|
|
||
| var loadDiagnostic = await textDocument.State.GetLoadDiagnosticAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
computation and returning of this diagnostic is pushed into FileContentLoadAnalyzer itself, instead of having to special case it here.
| foreach (var document in project.Documents) | ||
| { | ||
| // don't analyze documents whose content failed to load | ||
| if (failedDocuments == null || !failedDocuments.Contains(document)) |
There was a problem hiding this comment.
we don't need to track of the content failed to load. if it failed to load, it's just an empty string, which doesn't report diagnostics anyways.
|
|
||
| private sealed class HostAnalyzerInfo | ||
| { | ||
| private const int FileContentLoadAnalyzerPriority = -4; |
There was a problem hiding this comment.
moved into the FileContentloadAnalyzer.
| FileContentLoadAnalyzer _ => FileContentLoadAnalyzerPriority, | ||
| GeneratorDiagnosticsPlaceholderAnalyzer _ => GeneratorDiagnosticsPlaceholderAnalyzerPriority, | ||
| DocumentDiagnosticAnalyzer analyzer => Math.Max(0, analyzer.Priority), | ||
| DocumentDiagnosticAnalyzer analyzer => analyzer.Priority, |
There was a problem hiding this comment.
removed as we do just want to pass the priority through. Note that FileContentLoad is still pri -4, and the rest of the doc analyzers (which we own 100%) are all just at 50 and never change.
|
@JoeRobich ptal. |
2 participants
No description provided.