Skip to content

ProjectId can't be null with diagnostics #77886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2025
Merged

ProjectId can't be null with diagnostics #77886

merged 6 commits into from
Mar 28, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Mar 28, 2025

No description provided.

@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 28, 2025
@CyrusNajmabadi CyrusNajmabadi changed the title WIP: ProjectId can't be null with diagnostics ProjectId can't be null with diagnostics Mar 28, 2025
@CyrusNajmabadi CyrusNajmabadi requested a review from tmat March 28, 2025 00:13
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Mar 28, 2025

Tagging @tmat as hot reload was the only part that violated this. But i think there's a reasonable solution.

NOte: we need diags associated with projects as projects are the large granular unit that we query for off of hte IDiagANalyzerService (which is what the IDiagSources call to in pull diagnostics). This simplifies a lot of hte system and ensures a consistent view of all diagnostics (they're either with a project, or an optional doc within a project).

@CyrusNajmabadi CyrusNajmabadi requested a review from tmat March 28, 2025 17:40
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review March 28, 2025 18:27
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 28, 2025 18:27
@CyrusNajmabadi CyrusNajmabadi merged commit af3a096 into dotnet:release/dev17.15 Mar 28, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the projectId branch March 28, 2025 18:27
This was referenced Apr 19, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmat tmat tmat approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CyrusNajmabadi @tmat