Simplify the code for getting source generator diagnostics into the diagnostics service. #77898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iagnostics service
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
Member
Author
|
@dibarbet ptal. |
dibarbet
approved these changes
Mar 31, 2025
Comment on lines
141
to
+142
|
|
||
| result = await UpdateWithGeneratorFailuresAsync(result).ConfigureAwait(false); | ||
| // result = await UpdateWithGeneratorFailuresAsync(result).ConfigureAwait(false); |
Member
Author
There was a problem hiding this comment.
will do in update.
| // based on 'shouldIncludeDiagnostic' predicate. More specifically, TS has special document | ||
| // analyzer which report 0 supported diagnostics, but we always want to execute it. | ||
| // Special case DocumentDiagnosticAnalyzer to never skip these document analyzers based on | ||
| // 'shouldIncludeDiagnostic' predicate. More specifically, TS has special document analyzer which report |
Member
There was a problem hiding this comment.
TS has special document analyzer which report
// 0 supported diagnostics, but we always want to execute it.
is this still true, or has it moved off of roslyn?
Member
Author
There was a problem hiding this comment.
literally in the process of moving them off :) PR should go in this week.s
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.